[BUG] [INTERMITTENT] Querying any device after search on GSMArena returns "Invalid option" #50
Labels
No labels
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: ABOCN/TelegramBot#50
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
If you click on a specific device after search, this happens.
Worth noting that it only happens on production... If you try to run locally, this doesn't happen. Maybe Docker issue?
Have you already tried to update bot? I can't reproduce this error here
As I said later,
This only happens if you run on Docker lmao
ahh so it's docker issue, hmm
I'll check soon
@GiovaniFZ @ihatenodejs This only happens on LibreCloud server, doesn't matter if it is running on Docker or locally. GSMArena may have blocked us from accessing their servers on our VPS. Closing this issue since it doesn't matter anymore.
I don't believe this to be an issue with LibreCloud, as I was able to replicate this issue on a test bot I had setup on my laptop (please see below)
I use arch btw
I was able to make HTTP requests to GSMArena just fine, although the bot reported the same invalid option error when I tried to make requests through that. I still believe this to be an issue with the code, so I'll review this and some of the other bugs today.
I'm aware of our IPs blacklisted on
RATS-Spam
because of our host, although this only impacts email sending. I've contacted server.it about this, and I hope they will allocate us another IP. While it is a datacenter IP, I don't think we would have made enough requests.Maybe we should implement admin statistics (like how many requests have been made in the past hour, and especially ratelimiting.
Well, I have tried the bot itself locally and it worked here lmao
Can you give me the device name you tried? I was unsuccessful searching for the
Google Pixel 7 Pro
That's very strange... And you're sure your local repo is up-to-date?
Oh yea, it is lmao
It is also updated on the server tho
I'll take another look at this because I'm moving the server back to Felware, which seems to have a better IP reputation. Hopefully that will fix the issue, but I can always take another look
@ihatenodejs Please, do a clean clone but import the local DBs then, feel free to test
Closing this. If the issue happens again, I will reopen and we will discuss this better.
Back to this since it happened again with our new host. Any ideas, @ihatenodejs and @GiovaniFZ?
no idea for now, I will check soon