[BUG] [INTERMITTENT] Querying any device after search on GSMArena returns "Invalid option" #50

Open
opened 2025-05-01 15:34:41 +00:00 by lucmsilva651 · 16 comments
lucmsilva651 commented 2025-05-01 15:34:41 +00:00 (Migrated from github.com)

If you click on a specific device after search, this happens.
Worth noting that it only happens on production... If you try to run locally, this doesn't happen. Maybe Docker issue?

Image

If you click on a specific device after search, this happens.\ Worth noting that it only happens on production... If you try to run locally, this doesn't happen. Maybe Docker issue? > ![Image](https://github.com/user-attachments/assets/b9a1fb4f-f8f5-48fa-a0ef-8d429971a92e)
GiovaniFZ commented 2025-05-01 15:35:52 +00:00 (Migrated from github.com)

Have you already tried to update bot? I can't reproduce this error here

Have you already tried to update bot? I can't reproduce this error here
lucmsilva651 commented 2025-05-01 15:37:54 +00:00 (Migrated from github.com)

Have you already tried to update bot? I can't reproduce this error here

As I said later,

Worth noting that it only happens on production... If you try to run locally, this doesn't happen. Maybe Docker issue?

This only happens if you run on Docker lmao

> Have you already tried to update bot? I can't reproduce this error here As I said later, > Worth noting that it only happens on production... If you try to run locally, this doesn't happen. Maybe Docker issue? This only happens if you run on Docker lmao
GiovaniFZ commented 2025-05-01 19:39:12 +00:00 (Migrated from github.com)

ahh so it's docker issue, hmm

ahh so it's docker issue, hmm
GiovaniFZ commented 2025-05-01 19:39:23 +00:00 (Migrated from github.com)

I'll check soon

I'll check soon
lucmsilva651 commented 2025-05-02 04:16:23 +00:00 (Migrated from github.com)

@GiovaniFZ @ihatenodejs This only happens on LibreCloud server, doesn't matter if it is running on Docker or locally. GSMArena may have blocked us from accessing their servers on our VPS. Closing this issue since it doesn't matter anymore.

@GiovaniFZ @ihatenodejs This only happens on LibreCloud server, doesn't matter if it is running on Docker or locally. GSMArena may have blocked us from accessing their servers on our VPS. Closing this issue since it doesn't matter anymore.
ihatenodejs commented 2025-05-02 16:32:55 +00:00 (Migrated from github.com)

I don't believe this to be an issue with LibreCloud, as I was able to replicate this issue on a test bot I had setup on my laptop (please see below)

I use arch btw

I was able to make HTTP requests to GSMArena just fine, although the bot reported the same invalid option error when I tried to make requests through that. I still believe this to be an issue with the code, so I'll review this and some of the other bugs today.


I'm aware of our IPs blacklisted on RATS-Spam because of our host, although this only impacts email sending. I've contacted server.it about this, and I hope they will allocate us another IP. While it is a datacenter IP, I don't think we would have made enough requests.

Maybe we should implement admin statistics (like how many requests have been made in the past hour, and especially ratelimiting.

I don't believe this to be an issue with LibreCloud, as I was able to replicate this issue on a test bot I had setup on my laptop (please see below) # I use arch btw I was able to make HTTP requests to GSMArena just fine, although the bot reported the same invalid option error when I tried to make requests through that. I still believe this to be an issue with the code, so I'll review this and some of the other bugs today. --- I'm aware of our IPs blacklisted on `RATS-Spam` because of our host, although this only impacts email sending. I've contacted server.it about this, and I hope they will allocate us another IP. While it is a datacenter IP, I don't think we would have made enough requests. Maybe we should implement admin statistics (like how many requests have been made in the past hour, and *especially* ratelimiting.
lucmsilva651 commented 2025-05-02 17:09:46 +00:00 (Migrated from github.com)

I don't believe this to be an issue with LibreCloud, as I was able to replicate this issue on a test bot I had setup on my laptop (please see below)

I use arch btw

I was able to make HTTP requests to GSMArena just fine, although the bot reported the same invalid option error when I tried to make requests through that. I still believe this to be an issue with the code, so I'll review this and some of the other bugs today.

I'm aware of our IPs blacklisted on RATS-Spam because of our host, although this only impacts email sending. I've contacted server.it about this, and I hope they will allocate us another IP. While it is a datacenter IP, I don't think we would have made enough requests.

Maybe we should implement admin statistics (like how many requests have been made in the past hour, and especially ratelimiting.

Well, I have tried the bot itself locally and it worked here lmao

> I don't believe this to be an issue with LibreCloud, as I was able to replicate this issue on a test bot I had setup on my laptop (please see below) > > # I use arch btw > I was able to make HTTP requests to GSMArena just fine, although the bot reported the same invalid option error when I tried to make requests through that. I still believe this to be an issue with the code, so I'll review this and some of the other bugs today. > > I'm aware of our IPs blacklisted on `RATS-Spam` because of our host, although this only impacts email sending. I've contacted server.it about this, and I hope they will allocate us another IP. While it is a datacenter IP, I don't think we would have made enough requests. > > Maybe we should implement admin statistics (like how many requests have been made in the past hour, and _especially_ ratelimiting. Well, I have tried the bot itself locally and it worked here lmao
ihatenodejs commented 2025-05-02 22:32:25 +00:00 (Migrated from github.com)

Well, I have tried the bot itself locally and it worked here lmao

Can you give me the device name you tried? I was unsuccessful searching for the Google Pixel 7 Pro

> Well, I have tried the bot itself locally and it worked here lmao Can you give me the device name you tried? I was unsuccessful searching for the `Google Pixel 7 Pro`
lucmsilva651 commented 2025-05-02 22:49:03 +00:00 (Migrated from github.com)

Well, I have tried the bot itself locally and it worked here lmao

Can you give me the device name you tried? I was unsuccessful searching for the Google Pixel 7 Pro

Image

> > Well, I have tried the bot itself locally and it worked here lmao > > Can you give me the device name you tried? I was unsuccessful searching for the `Google Pixel 7 Pro` ![Image](https://github.com/user-attachments/assets/0daaa8a8-092e-472d-a180-0f005b2db398)
ihatenodejs commented 2025-05-03 00:19:03 +00:00 (Migrated from github.com)

That's very strange... And you're sure your local repo is up-to-date?

That's very strange... And you're sure your local repo is up-to-date?
lucmsilva651 commented 2025-05-03 01:47:37 +00:00 (Migrated from github.com)

That's very strange... And you're sure your local repo is up-to-date?

Oh yea, it is lmao
It is also updated on the server tho

> That's very strange... And you're sure your local repo is up-to-date? Oh yea, it is lmao It is also updated on the server tho
ihatenodejs commented 2025-05-04 18:07:14 +00:00 (Migrated from github.com)

I'll take another look at this because I'm moving the server back to Felware, which seems to have a better IP reputation. Hopefully that will fix the issue, but I can always take another look

I'll take another look at this because I'm moving the server back to Felware, which seems to have a better IP reputation. Hopefully that will fix the issue, but I can always take another look
lucmsilva651 commented 2025-05-04 18:08:13 +00:00 (Migrated from github.com)

@ihatenodejs Please, do a clean clone but import the local DBs then, feel free to test

@ihatenodejs Please, do a clean clone but import the local DBs then, feel free to test
lucmsilva651 commented 2025-05-27 13:07:37 +00:00 (Migrated from github.com)

Closing this. If the issue happens again, I will reopen and we will discuss this better.

Closing this. If the issue happens again, I will reopen and we will discuss this better.
lucmsilva651 commented 2025-06-06 17:44:18 +00:00 (Migrated from github.com)

Back to this since it happened again with our new host. Any ideas, @ihatenodejs and @GiovaniFZ?

Back to this since it happened again with our new host. Any ideas, @ihatenodejs and @GiovaniFZ?
GiovaniFZ commented 2025-06-08 14:41:02 +00:00 (Migrated from github.com)

no idea for now, I will check soon

no idea for now, I will check soon
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: ABOCN/TelegramBot#50
No description provided.